Re: svn commit: r24383 - trunk/subversion/tests/cmdline/svntest

hwright@tigris.org wrote:
> Author: hwright
> Date: Tue Apr 3 10:00:26 2007
> New Revision: 24383
>
> Log:
> In the test suite, use Python boolean values instead of integers masquerading
> as booleans.
>
> * subversion/test/cmdline/svntest/main.py:
> (windows, platform_with_os_wait, verbose_mode, cleanup_mode, enable_sasl):
> Use True and False, instead of 1 and 0.
>
>
> Modified:
> trunk/subversion/tests/cmdline/svntest/main.py
> [...]

What version of Python is required for the test suite?

The Python pseudo-boolean values True and False were only added in
Python 2.2.1, and true booleans (including the bool() built-in function)
only in 2.3.0:

    http://www.python.org/doc/2.3/whatsnew/section-bool.html

cvs2svn still supports Python 2.2, so we use a module boolean.py:

# Pretend we have true booleans on older python versions:
try:
  True
except:
  True = 1
  False = 0

try:
  bool
except:
  def bool(x):
    return not not x

which is imported like this:

from cvs2svn_lib.boolean import *

Depending on the Python version requirement, similar measures might be
required in svntest.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 5 11:06:46 2007