Re: [PATCH] Destroy the APR subpools

On Wed, 2007-04-04 at 09:00 -0400, C. Michael Pilato wrote:
> Bhuvaneswaran Arumugam wrote:
> > Thanks for the review comments Mike. Please find attached the revised
> > patch incorporating your comments. In addition, I've also bumped the
> > copyright year to 2007 in this patch.
>
> [...]
>
> > @@ -138,14 +138,15 @@
> > int i = 0;
> > void *parent_db = NULL, *db = NULL;
> > const char *path;
> > - apr_pool_t *subpool = svn_pool_create(pool);
> > - apr_pool_t *iterpool = svn_pool_create(pool);
> > - dir_stack_t *item = apr_pcalloc(subpool, sizeof(*item));
> >
> > /* Do nothing if there are no paths. */
> > if (! paths->nelts)
> > return SVN_NO_ERROR;
> >
> > + apr_pool_t *subpool = svn_pool_create(pool);
> > + apr_pool_t *iterpool = svn_pool_create(pool);
> > + dir_stack_t *item = apr_pcalloc(subpool, sizeof(*item));
> > +
> > /* Sort the paths in a depth-first directory-ish order. */
> > qsort(paths->elts, paths->nelts, paths->elt_size, svn_sort_compare_paths);
>
> This won't work in strict C compilers -- you can't have declarations
> following code in a function body. You'll want:
>
> apr_pool_t *subpool, *iterpool;
> dir_stack_t *item;
>
> if (! paths->nelts)
> return SVN_NO_ERROR;
>
> subpool = svn_pool_create(pool);
> iterpool = svn_pool_create(pool);
> item = apr_pcalloc(subpool, sizeof(*item));
>
> With those changes, +1 to commit.

I committed this patch with these changes in r24417. Thank you.

-- 
Regards,
Bhuvaneswaran