[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] In status -u, use target as anchor if target is a versioned directory.

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-04-03 17:08:48 CEST

Malcolm Rowe wrote:
> On Tue, Apr 03, 2007 at 02:43:38PM +0200, Lieven Govaerts wrote:
>> [[[
>> When the target of 'svn status' is a versioned directory, use this directory
>> as anchor instead of opening the parent directory.
>> * subversion/libsvn_client/status.c
>> (svn_client_status3): try to open the target directory, If this fails
>> because
>> target is a file or an unversioned directory), fall back to opening the
>> parent directory instead.
>> ]]]
> If you're right (that this is okay from a correctness standpoint, and
> that it's more efficient), this logic should be inlined directly into
> svn_wc_adm_open_anchor(), I'd have thought.
That thought crossed my mind, but svn_wc_adm_open_anchor is used in
other places too, where write locks are needed for instance. Are there
no situations where opening the parent directory is needed even when the
target is a directory?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 3 17:09:10 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.