Re: [PATCH] libsvn_fs_util: New library to reuse FSFS and BDBfunctions

On Mon, 02 Apr 2007, Bhuvaneswaran Arumugam wrote:

> On Sun, 2007-04-01 at 11:06 -0700, Daniel Rall wrote:
> > On Sat, 31 Mar 2007, Bhuvaneswaran Arumugam wrote:
> >
> > > Hello,
> > >
> > > Please find attached the patch for review.
> > >
> > > As of today, we have defined the functions both in libsvn_fs_fs and
> > > libsvn_fs_base libraries even though they are functionally identical.
> > > This patch creates the initial framework to re-use the utility functions
> > > used by FSFS and BDB file systems to avoid duplicate code lying in
> > > libraries related to FSFS and BDB file systems.
> >
> > +1 on the concept. Mike's been wanting to do this for quite some
> > time; it was part of the impetus for creating a new libsvn_fs_util
> > module in the first place.
> >
> > > For now, this patch defines a new function
> > > svn_fs__canonicalize_abspath() to canonicalize the absolute path. This
> > > function is a replacement for svn_fs_fs__canonicalize_abspath() and
> > > svn_fs_base__canonicalize_abspath() functions used internally by FSFS
> > > and BDB file systems respectively. The new function is also identical to
> > > the older counterpart.
> > >
> > > If this approach is right, we can define and re-use other possible
> > > functions to avoid duplicate code lying in libraries related to FSFS and
> > > BDB file systems. FWIW, I have run 'make check' with this patch and I
> > > have not noticed any issues.
> >
> > The patch looks good to me, but I haven't tested it. Bhuvan, have you
> > tested over ra_svn and ra_dav as well?
>
> I'm testing this patch over ra_svn and ra_dav support. I'll let you know
> how it goes.

My tests look good. I committed your patch to trunk in r24350.