Re: [neon] Re: Subversion/Neon win32 compilation

On Friday 30 March 2007 10:10, Yves Martin wrote:
> On Thu, 2007-03-29 at 16:10 +0200, Ulrich Eckhardt wrote:
> > > util.c
> > > ..\..\..\subversion\libsvn_ra_dav\util.c(688) : warning C4133:
> > > 'function' : incompatible types - from 'void (__cdecl *)(void *,const
> > > char *,size_t)' to 'ne_block_reader'
> >
> > Incompatible function pointers are an invitation for f***up. Note: for MS
> > Windows, the calling convention (__cdecl) is also an important part of
> > the function signature!
> >
> > Disclaimer: I have never compiled neon or SVN on win32.
>
> Thank you Ulrich for your answer.
> Have you got a proposal how to fix these issues ?
> Errors are marked on function pointer affectation but the "__cdecl"
> keyword is never explicitly written in any sources files.

About the __cdecl, you can set the default calling convention with a compiler
switch or override it in the code using the __cdecl attribute. In general,
don't mess with the compiler switch. Often, when such things are concerned,
the code in question hides it behind a macro that resolves to nothing on
platforms that don't use this.

> It seems "ne_decompress_reader" has four parameters in signature and the
> compiler expect only 3 ??

Okay, if that is the case you don't even need the calling convention to mess
up things. It simply means that the functions don't match. Why that is the
case, when this last used to work or how it should be fixed is beyond me, I'd
have to take a real look at the code.

> I'm trying to build Subversion 1.4.x (branch) with Neon 0.26.x (branch)
> as latest win32 releases are built with 0.26.3. But errors are the same
> with 0.25.x
>
> I really wonder who compiles win32 binary for Subversion and how ;)

Hmmm, since Tigris has binaries for download, someone obviously managed to do
it - have you asked them? Also, IIRC SVN includes branched copies of some
libraries in their own code, maybe you need to use those?

Uli

-- 
Sator Laser GmbH
Geschäftsführer: Ronald Boers, Amtsgericht Hamburg HR B62 932
**************************************************************************************
           Visit our website at <http://www.satorlaser.de/>
**************************************************************************************
Diese E-Mail einschließlich sämtlicher Anhänge ist nur für den Adressaten bestimmt und kann vertrauliche Informationen enthalten. Bitte benachrichtigen Sie den Absender umgehend, falls Sie nicht der beabsichtigte Empfänger sein sollten. Die E-Mail ist in diesem Fall zu löschen und darf weder gelesen, weitergeleitet, veröffentlicht oder anderweitig benutzt werden.
E-Mails können durch Dritte gelesen werden und Viren sowie nichtautorisierte Änderungen enthalten. Sator Laser GmbH ist für diese Folgen nicht verantwortlich.
**************************************************************************************
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org