[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] 'SVN_ERR_RA_DAV_PATH_NOT_FOUND' -> 'SVN_ERR_FS_NOT_FOUND'

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-03-29 12:39:08 CEST

> The reason for the special case for ra_dav is that unlike ra_local and
> ra_svn, the DAV plugins make requests of mod_dav_svn for things that don't
> map conceptually to Subversion repository filesystem paths. You don't
> MKACTIVITY on a Subversion filesystem path. You don't ask for OPTIONS on a
> Subversion filesystem path. And so on.
>
> Now, it's not clear to me what, if any, value we have in maintaining this
>

> distinction, but I don't think this is just a case of developer's
> accidentally failing to notice an already existing error code before
> creating a new one.
>
>
For me it seems accidental from the log message of r6532 since when
'SVN_ERR_RA_DAV_PATH_NOT_FOUND' exists.
<snip>
Patch from Shlomi Fish: resolves Issue #1267 ("have to say 'no'
several times to reject SSL certificate.') and probably other
misbehaviours.

* svn_error_codes.h: Added the SVN_ERR_RA_DAV_PATH_NOT_FOUND error code.

* props.c (svn_ra_dav__search_for_starting_props): now ignoring on the
  PATH_NOT_FOUND error instead of the more generic REQUEST_FAILED
  error.

* util.c (svn_ra_dav__parsed_request): check if the error code is 404
  and if so send a PATH_NOT_FOUND error. Else send a generic error.

* commit.c (commit_add_file): changed the REQUEST_FAILED error to
  PATH_NOT_FOUND, so it will be handled correctly as well.
</snip>

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 29 12:39:26 2007

This is an archived mail posted to the Subversion Dev mailing list.