[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: merge-tracking: Intentional reading of merge info outside a BDB transaction?

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-03-29 11:53:37 CEST

C. Michael Pilato wrote:
> Today, I was poking thru the BDB code, and noticed the new public FS APIs
> for merge tracking. As I dug into them a little bit deeper, though, I saw
> something that didn't seem quite right: base_txn_merge_info() doesn't wrap
> its read of the txn's proplist in a BDB transaction. Was that an
> intentional deviation from the way svn_fs_base__txn_proplist() works (even
> though the two are super-similar in functionality)?
>
>
Yes it is intentional.
If we use 'svn_fs_base__retry_txn' instead of 'svn_fs_base__retry' it
tries to open one more trail and hence aborts.

'begin_txn' in subversion/libsvn_fs_base/trail.c has the following comment,
<snip>
      /* [*]
         If we're already inside a trail operation, abort() -- this is
         a coding problem (and will likely hang the repository anyway). */

</snip>

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 29 11:54:00 2007

This is an archived mail posted to the Subversion Dev mailing list.