[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Re: [PATCH] Make sparse-directories checkouts/updates work with old servers

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-03-28 10:13:37 CEST

Karl Fogel writes:
> Vlad Georgescu <vgeorgescu@gmail.com> writes:
> > This patch makes checkouts and updates at svn_depth_empty and
> > svn_depth_immediates work with servers that do not understand the new
> > reporter changes, by making the update editor ignore edits on paths below
> > the edit depth.
> >
> > With this patch, I can successfully run the depth tests against a 1.4
> > svnserve. As this is my first attempt at sparse-directories related work,
> > I'm posting the patch here for review.
>
> Great! (Sanity check: is there definitely a test in there that tests
> the behavior we want?)
>

How could there be? We normally test current client against current servers.
Sometimes, when people do compatibility work, they run tests with
mixed server/client, but we don't have anything automatic for that.
OTOH, if you test a new client against an old server, then the regular
depth tests should fail if this code doesn't do what's intended.

I think it is a problem that we don't have automatic tests for our
client-server compatibility guarantees:( In this case, we could do with
some unittests for the update editor in libsvn_wc if someone has some
spare time...

thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 28 10:14:11 2007

This is an archived mail posted to the Subversion Dev mailing list.