Re: [PATCH] for sh portability issue in davautocheck.sh

Peter Samuelson wrote:
> [Louis Guillaume]
>> * subversion/tests/cmdline/davautocheck.sh
>> Fixed some instances of Bourne shell features that are not portable:
>> (1) Removed all instances of `==' in `test' or `[' statements.
>> (2) Replaced use of `$RANDOM' with `(( $$ % 32768 ))'.
>
> Uh ... I don't think you really mean "Bourne shell features". Because
> if you really want to target all Bourne shells, you also need to stop
> using $() syntax (use ``) and $(()) syntax (use `eval`). Also, you
> can't use shell functions, which is pretty inconvenient - just ask the
> autoconf maintainers!
>

> But I suppose you really meant POSIX shell compatibility,

Yes! That's what I meant...

> Maybe pkgsrc could learn a few tricks from checkbashisms:
>

I'll certainly forward your original message to the pkgsrc lists. I think that's very helpful.

Thank you.

Louis

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 27 06:49:03 2007