[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_client_diff3's API is broke (Re: svn commit: r23994)

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-03-27 01:53:25 CEST

On Fri, 23 Mar 2007, Kouhei Sutou wrote:

> Hi,
>
> I changed subject.
>
> > Hi,
> >
> > 2007/3/22, kfogel@tigris.org <kfogel@tigris.org>:
> > > Author: kfogel
> >
> > ==============================================================================
> > > --- trunk/subversion/include/svn_client.h (original)
> > > +++ trunk/subversion/include/svn_client.h Wed Mar 21 19:20:47 2007
> >
> > > @@ -931,7 +940,7 @@
> > > const char *path,
> > > const svn_opt_revision_t *peg_revision,
> > > const svn_opt_revision_t *revision,
> > > - svn_boolean_t recurse,
> > > + svn_depth_t depth,
> > > svn_boolean_t ignore_externals,
> > > svn_boolean_t allow_unver_obstructions,
> > > svn_client_ctx_t *ctx,
> >
> > This change breaks svn_client_diff3 API introduced in 1.3.
> > Is it OK?

This was not okay. I fixed it in r24063.

Thanks Kou,
- Dan

  • application/pgp-signature attachment: stored
Received on Tue Mar 27 01:58:18 2007

This is an archived mail posted to the Subversion Dev mailing list.