[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnadmin dump/verify/load uses svn_path_join

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-03-24 14:47:23 CET

Paul Burba wrote:
> Hi Lieven,
>
> svn_dirent_is_absolute is all that is required at least in the problem I
> mentioned above. Note that the workaround I have in place is only
> needed in once place, so the impact is not currently widespread.
>
I'll make a patch for svn_dirent_is_absolute and send it to the list, I will only need it later when adapting the path functions to dirent/uri.

>>> How is "c:hi" an absolute path on Windows? Isn't "c:hi" really the
>>> equivalent of "c:.\hi"?
>>>
>>>
>> Depending on the way you look at 'c:hi' it's both absolute
>> and relative.
>> Your example makes it look like a relative path. However, a
>> relative path can be added to the current working directory
>> to make an absolute path, but you can't do that with 'c:hi'.
>> So for practical reasons 'c:hi'
>> type of paths are considered absolute.
>>
>
> Heh, you lost me there, but it's late am and I'm a bit fried. Could you
> maybe give me an example where "c:hi" would be absolute? I'm just not
> seeing it :-\
>
>
It was 3:40AM when I wrote that mail, no wonder you don't see it ;)

What I'm saying is this: an absolute path = current working directory +
a relative path. So suppose I do this:
c:\svn\wc\> svn diff test.txt

In this example Subversion can get the full path of test.txt by
concatenating 'c:\svn\wc\' and 'test.txt'. I don't know if 'svn diff'
actually uses the absolute path, but this is basically what
svn_path_join does.

Now take this example:
c:\svn\wc\> svn diff G:test.txt

If 'G:test.txt' would be considered a relative path, then Subversion
would think 'c:\svn\wc\G:test.txt' is the absolute path for test.txt,
which clearly is incorrect. So for practical reasons we consider
'G:test.txt' as an absolute path, but you're right in saying
conceptually it's actually relative.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 24 14:47:42 2007

This is an archived mail posted to the Subversion Dev mailing list.