[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [sparse-directories] Depth parameter for the editor API

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-03-24 08:27:26 CET

Daniel Rall <dlr@collab.net> writes:
> On Thu, 22 Mar 2007, Malcolm Rowe wrote:
>
>> On Wed, Mar 21, 2007 at 12:34:19PM -0700, Daniel Rall wrote:
>> > code. Malcolm and I were wondering if the new set_path()/link_path()
>> > APIs should actually error out if svn_depth_unknown is passed to them.
>>
>> In fact, I was asserting that they _should_ do so, unless there's a
>> sensible meaning we can assign to that combination. This depth stuff is
>> hard enough without adding extra confusion into the mix :-).
>
> I was okay with this too. Karl, what do you think?

I think I agree. Here's why:

There are some circumstances where passing svn_depth_unknown is
meaningful. For example, in libsvn_client, it usually means "no depth
was explicitly requested, so read the depth from the working copy".
But when talking to the server, the client should always specify an
explicit depth -- if nothing else, the client should be the one
deciding a default depth, so it should default to svn_depth_infinity
for set_path/link_path if it doesn't have anything better to suggest.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 24 08:27:41 2007

This is an archived mail posted to the Subversion Dev mailing list.