[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Clear neon_auth_types before adding http_auth_types from server config

From: Jens Peters <jpeters7677_at_gmx.de>
Date: 2007-03-24 00:27:03 CET

> Nice catch, Jens!

Hello Daniel,

Thank you for reviewing and fixing this issue. I have to admit that your version reads somewhat more
logical than mine :)

> This check isn't quite right: GSSPI is also a factor, and is it
> appropriate to use && in conjunction with an #ifdef?

Ok, I haven't seen HAVE_GSSAPI in the config.hw for Windows. But I have to admit I don't know if and
how neons GSSAPI implementation works on Windows. Will neon authenticate without asking for
credentials with GSSAPI as well?

> I haven't compiled it, but the formatting on this warning text looks
> like it's going to push this out too far (exceeding 79 columns).

The number of column were 73, but I should start the string at the beginning of the source line,
that way its more readable.

A newer version, but still without GSSAPI recognition.

[[[
* subversion/svn/main.c
  Add help output text that --username ARG and --password ARG
  is ignored if SSPI authentication is used
]]]

Index: subversion/svn/main.c
===================================================================
--- subversion/svn/main.c (revision 24060)
+++ subversion/svn/main.c (working copy)
@@ -92,10 +92,19 @@
                      N_("show program version information")},
    {"verbose", 'v', 0, N_("print extra information")},
    {"show-updates", 'u', 0, N_("display update information")},
+#if defined(WIN32) && defined(HAVE_SSPI)
+ {"username", svn_cl__auth_username_opt, 1,N_(
+ "specify a username ARG\n"
+ " ARG is ignored if SSPI authentication is used.")},
+ {"password", svn_cl__auth_password_opt, 1,N_(
+ "specify a password ARG\n"
+ " ARG is ignored if SSPI authentication is used.")},
+#else
    {"username", svn_cl__auth_username_opt, 1,
                      N_("specify a username ARG")},
    {"password", svn_cl__auth_password_opt, 1,
                      N_("specify a password ARG")},
+#endif
  #ifndef AS400
    {"extensions", 'x', 1,
                      N_("Default: '-u'. When Subversion is invoking an\n"

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 24 00:28:04 2007

This is an archived mail posted to the Subversion Dev mailing list.