[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] Make Ruby Windows bindings tests sqlite3 aware.

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-03-23 20:26:07 CET

Joe, I broke your patch into two parts (since it wasn't clear to me
that the changes were coupled), and committed them to trunk in r24057
and r24059.

Thanks, Dan

On Fri, 23 Mar 2007, Joe Swatosh wrote:

> [[
> Ruby windows bindings depend on sqlite3 and make sure the path doesn't get
> any
> \n's.
>
> * subversion/bindings/swig/ruby/test/windows_util.rb
> (SvnTestUtil::Windows::Svnserve#setup_svnserve): Add sqlite3.dll to the
> targets needed to start svnserve.
> (SvnTestUtil::Windows::SetupEnvironment#add_apr_dll_path_to_dll_wrapper_util):
> chomp the lines from gen-make.opt so no \n's make it onto the path
> ]]
>
>
> Index: subversion/bindings/swig/ruby/test/windows_util.rb
> ===================================================================
> --- subversion/bindings/swig/ruby/test/windows_util.rb (revision 24047)
> +++ subversion/bindings/swig/ruby/test/windows_util.rb (working copy)
> @@ -50,7 +50,7 @@
> end
> targets = %w(svnserve.exe libsvn_subr-1.dll libsvn_repos-1.dll
> libsvn_fs-1.dll libsvn_delta-1.dll
> - libaprutil.dll libapr.dll)
> + libaprutil.dll libapr.dll sqlite3.dll)
> ENV["PATH"].split(";").each do |path|
> found_targets = []
> targets.each do |target|
> @@ -160,7 +160,7 @@
> lines = File.read(gen_make_opts).to_a if File.exists?(gen_make_opts)
> config = {}
> lines.each do |line|
> - name, value = line.split(/\s*=\s*/, 2)
> + name, value = line.chomp.split(/\s*=\s*/, 2)
> config[name] = value if value
> end

  • application/pgp-signature attachment: stored
Received on Fri Mar 23 20:30:46 2007

This is an archived mail posted to the Subversion Dev mailing list.