[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_range_dup (svn commit: r24027)

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-03-23 06:03:50 CET

On Fri, 23 Mar 2007, Kouhei Sutou wrote:

> Hi,
>
> 2007/3/23, dlr@tigris.org <dlr@tigris.org>:
> >Author: dlr
> >Date: Thu Mar 22 14:11:00 2007
> >New Revision: 24027
>
> >Log:
> >Merge the merge-tracking branch to trunk.
>
> >Modified: trunk/subversion/include/svn_types.h
> >URL:
> >http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_types.h?pathrev=24027&r1=24026&r2=24027
> >==============================================================================
> >--- trunk/subversion/include/svn_types.h (original)
> >+++ trunk/subversion/include/svn_types.h Thu Mar 22 14:11:00 2007
> >@@ -702,6 +702,24 @@
>
> >+/**
> >+ * Return a copy of @a range, allocated in @a pool.
> >+ *
> >+ * @since New in 1.5.
> >+ */
> >+svn_merge_range_t *
> >+svn_range_dup(svn_merge_range_t *range, apr_pool_t *pool);
> >+
>
> I think we should rename to svn_merge_range_dup to unify other
> function name convention.

+1 -- feel free to make this change.

> By the way, why do we use 'mergeinfo' prefix instead of 'merge_info'
> prefix? I'm confused because
> subversion/include/private/svn_fs_merge_info.h uses 'merge_info' prefix
> as its filename and some names.

I prefer "merge info" (since it's two words). I think "mergeinfo" was
used as the library prefix as a simple abbreviation. I suppose we
should change to "mergeinfo" for the sake of consistency.

Thanks for the review, Kou.

- Dan

  • application/pgp-signature attachment: stored
Received on Fri Mar 23 06:09:13 2007

This is an archived mail posted to the Subversion Dev mailing list.