[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 2748] Non-UTF8 filenames can enter repository mounted as WebDAV drive

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-03-22 11:08:29 CET

On Wed, Mar 21, 2007 at 12:13:31PM -0400, C. Michael Pilato wrote:
> > In the past, there've been discussions about where validation should
> > occur. Shouldn't this kind of validation occur in the repository or
> > filesystem layers, or should the filesystem just treat a filename as a
> > string of bytes?
> The filesystem lives behind and API that demands UTF-8, Subversion-canonical
> So I think we want parity with the client side in terms of where we check
> for valid paths. "Userland" input is expected to be misshapen and crazy,
> because it comes from users (not from programmers who know how to follow the
> rules of an API). So the borders we guards are the ones between the users
> and their entry point into our system.

Interesting. Bearing in mind that we have direct users of the svn_fs_*
API, I'd place the interface boundary around each module, for pretty
much the same reasons as you'd draw it outside of mod_dav_svn.

(Incidentally, where can I find these "programmers who know how to
follow the rules of an API"? :-))


  • application/pgp-signature attachment: stored
Received on Thu Mar 22 12:49:25 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.