[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] svn_load_dirs.pl: importing new version of non-writable file fails

From: Mark Reibert <svn_at_reibert.com>
Date: 2007-03-22 09:02:00 CET

Hello,

svn_load_dirs.pl does not handle non-writable files in the staging
working copy when it copies files from the import directory. This
situation naturally occurs if the "svn:needs-lock" property is set on a
file. The attached patch addresses this by calling "svn lock" if the
target is non-writable. This is done for objects that have a MD5
computed, which brings us to ...

The script is computing MD5s for plain files *and* links, provided the
target of the link is a plain file. This does not seem correct since,
for example, what if the link pointed to a file outside the tree under
revision control? After all, if the link target is inside the tree the
script will find it as well as the link. The attached patch deals with
this issue by computing a MD5 only for plain files (and is a
pre-condition for the "svn lock" change).

Existing locks are not stolen. Should they be?

[[[
* contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in
  Attempt to get a lock for updates to read-only files.
  Compute MD5 only for plain file objects.
]]]

-- 
----------------------
Mark S. Reibert, Ph.D.
svn@reibert.com
----------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Thu Mar 22 09:02:14 2007

This is an archived mail posted to the Subversion Dev mailing list.