[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] client.rb has too many 'end's

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2007-03-22 08:21:16 CET

Hi,

2007/3/22, Joe Swatosh <joe.swatosh@gmail.com>:
> [[[
> * subversion/bindings/swig/ruby/svn/client.rb
> CommitItem3 class had too many end's
> Removed unneeded require
> ]]]

Thanks for reporting. I've fixed.

> 2) Error:
> test_diff(SvnClientTest):
> TypeError: can't convert true into Integer
> D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:81:in
> `svn_client_diff3'
> D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:81:in `diff3'
> D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/client.rb:221:in `diff'
> D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:690:in
> `test_diff'

This is caued by r23994. The commit breaks existing API of
svn_client_diff3. I think the change of svn_client_diff3 should be
reverted.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 22 08:21:27 2007

This is an archived mail posted to the Subversion Dev mailing list.