Re: [Patch] JavaHL add an implementation of BlameCallback and change code to use it
On 3/20/07, Hyrum K. Wright <email@example.com> wrote:
> Mark Phippard wrote:
> > I have attached a patch that does what we discussed on IRC. It adds an
> > implementation of BlameCallback to JavaHL and then changes SVNClient and
> > BasicTests to use it. This gets rid of the duplicate internal
> > BlameReceiver
> > class.
> > I am not setup to build Subversion at the moment, so I cannot run the
> > suite. The code formatting and JavaDoc of the new class also might not
> > up to standards. I can fix it up, I just wanted to see if I am on the
> > right
> > track with the patch.
> Aside from the large quantity of tab characters, things look okay. I
> applied the patch and ran the test suite, with no problems. Does the
> BlameLine class need to be public, or can it be protected? It is only
> used internally, and only gets returned from the protected
> getBlameLine() method.
I will make it private. I do not think it should be exposed. I will also
look into the tab characters. I need to review my Eclipse formatting
preferences. I wanted to make sure it worked first and the general idea was
in line with what dlr was suggesting.
Received on Tue Mar 20 22:49:58 2007
This is an archived mail posted to the Subversion Dev