[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_wc_ventry(_ex) to eliminate heavily repeated code

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-03-19 22:27:37 CET

On Mon, Mar 19, 2007 at 02:14:42PM -0700, Daniel Rall wrote:
> > You are aware that all svn_*__ symbols are exported from the libraries
> > (at least on Linux) too?
>
> As Vlad suggested on IRC, we now have the include/private/ area. Paul
> and I recently created a svn_wc_private.h in there for a
> project-private API that we don't want exported by our public header
> files.
>

I think Erik was referring to exports from the libraries, rather than
'exports' from the header files. We export all sorts of fun functions
from the existing libraries: try e.g. nm /usr/local/lib/libsvn_fs_fs-1.so
sometime. (With sufficient fiddling with gcc, we could actually remove
most of these, but it doesn't seem to me like that would be a worthwhile
effort).

> Our svn_*__* APIs can start following this pattern. HACKING should be
> updated to recommend its usage.

Only for those that are currently _in_ the public header files, and not
the private intra-library calls, I assume :-)

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Mon Mar 19 22:27:53 2007

This is an archived mail posted to the Subversion Dev mailing list.