[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23740 - branches/merge-tracking/subversion/tests/libsvn_subr

From: David Glasser <glasser_at_mit.edu>
Date: 2007-03-19 03:09:53 CET

On 3/8/07, pburba@tigris.org <pburba@tigris.org> wrote:
> static const char *mergeinfo1 = "/trunk: 5,7-9,10,11,13,14,3\n/fred:8-10";
> static const char *mergeinfo2 = "/trunk: 1-4,6,3\n/fred:9-12";
> -static const char *mergeinfo3 = "/trunk: 3-7, 13\n/fred:9";
> -static const char *mergeinfo4 = "/trunk: 5-8, 13\n/fred:9";
> static const char *mergeinfo5 = "/trunk: 15-25, 35-45, 55-65";
> static const char *mergeinfo6 = "/trunk: 15-25, 35-45";
> static const char *mergeinfo7 = "/trunk: 10-30, 35-45, 55-65";

This seems a little odd --- shouldn't we renumber the larger-numbered
variables to not leave a gap?

(And is there a compelling reason to have these constants separated
out instead of inline, closer to where they're actually used?)

--dave, catching up on weeks of svn-dev mail

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 19 03:10:12 2007

This is an archived mail posted to the Subversion Dev mailing list.