[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 1789] large 'svn diff' fails on win32

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-03-17 15:10:54 CET

On 3/17/07, Lieven Govaerts <svnlgo@mobsol.be> wrote:
> dionisos@tigris.org wrote:
> > http://subversion.tigris.org/issues/show_bug.cgi?id=1789
> >
> > ------- Additional comments from dionisos@tigris.org Thu Mar 15 15:56:14 -0700 2007 -------
> > Created an attachment (id=629)
> > Patch for Win32 to chunk large writes to console handles
> >
> >
> Erik,
> attached is an updated version of your patch. I tested with a 400kb hunk
> and that worked ok.

That's great!

Now that we have a working & tested patch, the question is whether we
have to wait for APR to incorporate this patch.

> One thing I'm not sure of is on what error messages we'll have to check.
> When I run the test the error is ERROR_NOT_ENOUGH_MEMORY, which is one
> of the two error messages MSDN lists as possible outcome of WriteFile,
> the other being ERROR_INVALID_USER_BUFFER. I don't know where you got
> the error message from that you used in your patch? I didn't find more
> details about those error messages, maybe we should just check for all
> of the three?

No idea, I just looked at the error message reported by the user and
looked for the error with the constant which looked most alike. I
think your ERROR_NOT_ENOUGH_MEMORY will be a good start to close the
issue. If other errors get reported, we'll address them the same way.

Thanks for having a look!



To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 17 15:11:09 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.