[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r23815 broke authz_tets under svnserve

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-03-17 00:02:39 CET

Peter Lundblad wrote:
> Hi, Dave,
>
> It seems like r23815 has changed an error string and hence breaks a test:
> CMD: svnadmin "create" "svn-test-work/repositories/authz_tests-10" "--bdb-txn-nosync" <TIME = 0.150935>
> CMD: svnadmin dump "svn-test-work/local_tmp/repos" | svnadmin load "svn-test-work/repositories/authz_tests-10" <TIME = 0.106903>
> CMD: svn "cp" "--username" "jconstant" "--password" "rayjandom" "-m" "logmsg" "svn://127.0.0.1:27465/svn-test-work/repositories/authz_tests-10/iota" "svn://127.0.0.1:27465/svn-test-work/repositories/authz_tests-10/A/B" "--config-dir" "/usr/local/google/src/svn/trunk3/subversion/tests/cmdline/svn-test-work/local_tmp/config" <TIME = 0.212298>
> EXPECTED STDERR (regexp):
> .*svn: Access denied.*
> ACTUAL STDERR:
> subversion/svnserve/serve.c:445: (apr_err=170001)
> svn: Authorization failed
> EXCEPTION: SVNLineUnequal
> FAIL: authz_tests.py 10: test authz for aliases
>
> It is tempting to just fix the test, but I don't want to do that because I'm
> not sure what's causing this change.
>
> Reverting this revision makes the failure go away.
>
I changed the error message to get the buildslaves back in green.

Why do we have the 'Access denied' error message in the first place? I
see David added it in r15608 in libsvn_repos/commit.c and that's as far
as I can see the only place where this message is used.

David, can we just drop the 'Access denied' message and replace it with
the standard 'Authorization failed' error? Or is there a reason to
differentiate between the two?

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 17 00:02:58 2007

This is an archived mail posted to the Subversion Dev mailing list.