[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: JavaHL bindings cleanup

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-03-16 16:33:12 CET

On 3/16/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
>
> I've been mucking around in the JavaHL bindings the past few days, and I
> have the following suggestions:
>
> 1) Update the .cpp and .java files to use the same coding style that the
> main codebase uses.

I am not sure it makes sense to force the .java files to follow a style used
in C/C++, but to be honest I am not familiar with the scope of what that
would mean. Maybe not much. For me, since I use tools like Eclipse, I
would just want the style to be something reasonable that I can set in
Eclipse and let it handle for me.

2) Rearrange methods within classes in alphabetical order, with older
> methods first in the case of overloaded methods.
>
> 3) Implement older APIs as wrappers around newer APIs in the same class.
> (Currently, some are implemented as wrappers around newer APIs in
> other classes.)
>
> I think this would improve maintainability substantially, but I wanted
> to know what others thought. Comments? Objections?

In general I am fine with the concept. I do not know what #3 means at a
technical level so cannot comment. Obviously the main issue is that the
changes do not make it too hard to backport future fixes, but I would say
that the number of those are likely to be a number approaching zero. So
better to do this now, well in advance of a 1.5 branch.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on Fri Mar 16 16:33:23 2007

This is an archived mail posted to the Subversion Dev mailing list.