[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [bug] possible pool leak in Ruby bindings for FS?

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: 2007-03-16 15:28:33 CET

Hi kou,

On 3/16/07, Kouhei Sutou <kou@cozmixng.org> wrote:
> Hi,
>
> In <ae6cb1100703150738y1c22a5b9r5c739b26f125bcdf@mail.gmail.com>
> "Re: [bug] possible pool leak in Ruby bindings for FS?" on Thu, 15 Mar 2007 07:38:04 -0700,
> "Joe Swatosh" <joe.swatosh@gmail.com> wrote:
>
> > > > Put still errors during teardown:
> > >
> > > I found that this problem can be solved by destroying
> > > stream's pool.
> > >
> > > pool = Svn::Core::Pool.new
> > > stream = @fs.root(rev2).file_delta_stream(@fs.root(rev1),
> > > path_in_repos,
> > > path_in_repos,
> > > pool)
> > > ...
> > > pool.destroy
> > >
> > > I'll provide more good mechanism. (What about stream.close???)
> > >
> >
> > Is this another place for a block-form? That seems most "rubyish."
>
> I think so too after I mailed. But I realized that this
> problem is a bug related fs.root.close/repos.close. So, I
> fixed this problem by other way.
>
>
> Thanks,
> --
> kou
>

Your fix works.

--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 16 15:28:53 2007

This is an archived mail posted to the Subversion Dev mailing list.