[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [bug] possible pool leak in Ruby bindings for FS?

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2007-03-15 11:43:29 CET

Hi,

In <ae6cb1100703142206h1144a285h131c915e31be8ffc@mail.gmail.com>
  "Re: [bug] possible pool leak in Ruby bindings for FS?" on Wed, 14 Mar 2007 22:06:24 -0700,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:

> > > Could you try the attached patch? If the attached patch
> > > doesn't pass this test, I'll apply your patch.
> > >
> >
> > Sure, but I won't be able to get to it until this evening.
> >
>
> Almost, needs one more normalize_line_break at line 325 to make it
> through the test:

Thanks! I've committed.

> Put still errors during teardown:

I found that this problem can be solved by destroying
stream's pool.

  pool = Svn::Core::Pool.new
  stream = @fs.root(rev2).file_delta_stream(@fs.root(rev1),
                                            path_in_repos,
                                            path_in_repos,
                                            pool)
  ...
  pool.destroy

I'll provide more good mechanism. (What about stream.close???)

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 15 11:43:47 2007

This is an archived mail posted to the Subversion Dev mailing list.