Re: [Patch] Automatically trust valid certificates on windows via CryptoApi

On 3/14/07, Ivan Zhakov <chemodax@gmail.com> wrote:
> On 3/12/07, Bert Huijben <bert@vmoo.com> wrote:
> > > Hi Bert,
> > >
> > > I like idea of your patch and patch itself. I've not tested and
> > > carefully reviewed it yet. I'll do it ASAP.
> > >
> > > Would you also please provide the change log message for this commit, as
> > > described in HACKING?
> >
> > Hi Ivan,
> >
> > Thanks for looking into it.
> >
> > I hope the following log message matches the guidelines:
> Hi Bert, thank you for log message. Your patch looks very good, it
> just needs several improvements.
>
> First I think that svn_auth_get_windows_ssl_server_trust_provider
> should go to subversion/libsvn_subr/ssl_server_trust_providers.c
> instead of simple_providers.c
>
> Also please find several comments/questions inside the patch:
>
[snip
>

Hi, Bert!
I had some free time, so I've fixed these issues (and some others) and
committed your patch in r23812. Thanks a lot!

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org