[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [bug] possible pool leak in Ruby bindings for FS?

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2007-03-14 11:32:26 CET

Hi Joe,

In <ae6cb1100703132239p60247e70i865f3bb315ab64dc@mail.gmail.com>
  "[bug] possible pool leak in Ruby bindings for FS?" on Tue, 13 Mar 2007 22:39:42 -0700,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:

> I realize that you want to not use the binary file access when testing
> on windows, but I was fiddling around with this patch (which does
> cause the test to pass, but see below for how the test cleanup blows
> out sideways).

OK. I'll check cause for this problem.

> ===================================================================
> --- subversion/bindings/swig/ruby/test/test_fs.rb (revision 23804)
> +++ subversion/bindings/swig/ruby/test/test_fs.rb (working copy)

Could you try the attached patch? If the attached patch
doesn't pass this test, I'll apply your patch.

Thanks,

--
kou

Index: subversion/bindings/swig/ruby/test/test_fs.rb
===================================================================
--- subversion/bindings/swig/ruby/test/test_fs.rb (revision 23810)
+++ subversion/bindings/swig/ruby/test/test_fs.rb (working copy)
@@ -308,9 +308,9 @@
 
     File.open(path, "w") {|f| f.print(modified)}
     @fs.transaction do |txn|
- checksum = MD5.new(result).hexdigest
+ checksum = MD5.new(normalize_line_break(result)).hexdigest
       stream = txn.root.apply_text(path_in_repos, checksum)
- stream.write(result)
+ stream.write(normalize_line_break(result))
       stream.close
     end
     ctx.up(@wc_path)
@@ -329,8 +329,8 @@
     
     File.open(path, "w") {|f| f.print(modified)}
     @fs.transaction do |txn|
- base_checksum = MD5.new(src).hexdigest
- checksum = MD5.new(result).hexdigest
+ base_checksum = MD5.new(normalize_line_break(src)).hexdigest
+ checksum = MD5.new(normalize_line_break(result)).hexdigest
       handler = txn.root.apply_textdelta(path_in_repos,
                                          base_checksum, checksum)
       assert_raises(Svn::Error::ChecksumMismatch) do

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 14 11:37:04 2007

This is an archived mail posted to the Subversion Dev mailing list.