[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svnadmin dump/verify/load uses svn_path_join

From: D.J. Heap <djheap_at_gmail.com>
Date: 2007-03-14 00:43:40 CET

On 3/13/07, Lieven Govaerts <svnlgo@mobsol.be> wrote:
[snip]
>
> Problem is, not all path functions can handle all those four cases at
> the same time.
> Example: svn_path_join("/", "c:hi") in the above four cases returns:
> 1+2: c:hi because c:hi is an absolute path on Windows
> 3: n/a
> 4: /c:hi
>
> Now svn_path_join is used over 350 times in the Subversion code, in all
> of the 4 cases. The same goes for svn_path_dirname, svn_path_basename etc.

Ugh, I didn't realize it was that bad.

>
> To be honest, I don't see many other options than to revert the whole
> windows path thing and start from scratch on a feature branch. We'd have
> to work out all different usage patterns of the path functions, create
> new path functions for native, url, internal paths, and start using them
> throughout the code. To test all that a new test case has to be created
> to test all possible svn manipulations on 'c:hi' folders.
>
> What do you think?
>

Yeah, that may be what is needed. As it stands, we've got a pretty
severe compatibility problem with repository paths at least.

Do you think it would be feasible to just fix the repository-path
uses? Or do you think that would leave a lot of similar lurking
problems and we're better off analyzing and fixing them all at once?

I've only encountered the repository-path problem and I've been
testing trunk code pretty heavily on a few repositories for a while --
but we have very few oddball names like that.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 14 00:43:54 2007

This is an archived mail posted to the Subversion Dev mailing list.