On 3/12/07, Erik Huelsmann <ehuels@gmail.com> wrote:
> On 3/12/07, Ivan Zhakov <chemodax@gmail.com> wrote:
> > Hi Erik,
> >
> > I've no thoughts about idea itself, but I've several comments about
> > implementation.
> > - According documentation getenv() returns NULL if environment variable didn't
> > set. You don't check this.
>
> I do now. Yes, this made my client segfault before I noticed.
>
> > - I propose to make semantic of variable similar as SVN_ASP_DOT_NET_HACK.
> > I.e. make variable SVN_NO_SLEEP_FOR_TIMESTAMPS and doesn't care
> > about it's contents.
>
> Well, it is easy to set the value to 'yes' or 'no' from python. I
> haven't studied how to delete the variable from the environment
> entirely (from python). That's why I took the value into account.
If you "del" the proper python environment entry, it will get deleted
from the process environment.
Having said that. If this code is always enabled, then someone will
find and abuse it. It should only be enabled if the behavior is
correct in all cases.
It should be explicitly enabled at compile time and indicate that it
was built in maintainer mode (maybe in the version string).
-Dan C
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 12 21:21:57 2007