[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23782 - trunk/subversion/libsvn_wc

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-03-12 10:30:35 CET

kfogel@tigris.org writes:
> Author: kfogel
> Date: Mon Mar 12 00:08:52 2007
> New Revision: 23782
>
> Log:
> Follow up to r23767 with some input validation:
>
> * subversion/libsvn_wc/entries.c
> (read_entry): Error on invalid or missing working-size.
>
> Why aren't we validating the other stuff we read from .svn/entries?

Aren't we (except for the bug you fixed, of course)?

> Ideally, bad data in the entries file shouldn't cause the client to
> seg fault (as it just did for me, because my experimental working
> copies had 'depth' where 'working-size' should be).

Definitely! We can't trust data on disk.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 12 10:30:56 2007

This is an archived mail posted to the Subversion Dev mailing list.