[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23767 - in trunk/subversion: include libsvn_wc

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-03-12 08:39:17 CET

dionisos@tigris.org writes:
> Log:
> --- trunk/subversion/include/svn_wc.h (original)
> +++ trunk/subversion/include/svn_wc.h Sat Mar 10 03:22:25 2007
> @@ -1384,6 +1384,12 @@
> */
> const char *changelist;
>
> + /** Size of the file after being translated into local representation,
> + * or 0 if unknown.
> + * @since New in 1.5.
> + */
> + apr_off_t working_size;

Hmm, why "0" for unknown? Since files can be 0 bytes long, why not
use -1 or some other impossible number to represent "unknown"?

(Later, in r23770, you added text saying "negative if the file is
locally modified so the working size couldn't be recorded". That
would become -2 or some other specific value, I guess.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 12 08:39:37 2007

This is an archived mail posted to the Subversion Dev mailing list.