Re: [PATCH] Add anonymous user and inverted authz rule matching.

On 3/8/07, Jonathan Gilbert <o2w9gs702@sneakemail.com> wrote:
> I'm not really sure how to do that, but if I remember and have some spare
> time, I'm sure I can figure it out :-) If you were hoping to have them
> before doing the check-in, then it'd probably be better if you did them. If
> it's okay for them to arrive over the week-end, then I'll put it on my TODO
> list.

This weekend would be fine. I'll ping you on sunday if I don't see anything.

> I did notice one thing in the patch, a comment I neglected to update when
> switching from having '$' to having '$authenticated':

Fixed.

> For what it's worth, while I didn't have a Subversion unit test for these
> changes, their initial development was done in a separate mini-project
> which tested them before I went and integrated them into authz.c.

Sure, the code looks good now. I don't actually want unit testing for
these feature because I want to make sure they work. It's so that we
can make sure that, six months from now, they're still working. Just a
general increase in our future trust of the code by having our
buildbots bless them periodically.

Nevertheless, I'll submit this patch as it now stands. Is the email
you're posting from okay to include in the svn commit log message?

- Dave

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 8 16:36:12 2007