[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Testers wanted for FSFS svnadmin recover feature (r23595)

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-03-08 05:43:56 CET

On Wed, Mar 07, 2007 at 11:31:21PM -0500, David Glasser wrote:
> >You're saying the "lock acquired" message is appropriate even for FSFS?
>
> My impression is that printing a "lock acquired" message is
> appropriate for FSFS, but the time it is printed is too early. (The
> current svn_fs_fs__recover implementation wraps most of the
> calculation in a write lock on the repository, but this isn't called
> until *after* svn_svn_recover2 calls the callback which prints the
> message.)
>

This is because the repository layer is reponsible for doing the locking
for a filesystem-layer function. Fixing that would be nice, since it's
only the filesystem that's in a position to know what locking is necessary.

Probably hard to do though.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Thu Mar 8 05:44:22 2007

This is an archived mail posted to the Subversion Dev mailing list.