plundblad@google.com (Peter Lundblad) writes:
> I'm taking a look at the sparse-directories branch and how the new
> extensions to the reporter work.
>
> I think I understand how the depth parameter to set_path and link_path work.
> It tells the editor driver what changes we want in a particular subtree
> and also that, unless paths under this subtree are reported differently, it
> can assume that we already have the subpaths corresponding to the reported
> depth. (Please correct me if I'm wrong).
>
> My question then is, why do we need a default depth argument to
> svn_repo_begin_report3 and the RA functions that indirectly call it?
> We always start a report by a call to set_path, establishing the depth of
> the target, which effectively becomes the default depth then.
> So can't we just get rid of the recurse flag and have the reporter user
> set the depth later on? The compatibility shim would just remember
> the recurse flag and pass it along as a depth value in the first
> set_path call.
>
> Am I missing something?
No, I don't think you're missing anything -- I think I was a bit too
rigid about always replacing 'recurse' booleans with svn_depth_t
'depth' parameters. In this case, it would have been better to just
get rid of the parameter entirely.
I'll take care of this as soon as I commit up my current set of
changes, which is about creating the svn_wc_get_status_editor3() API.
(In that case, I think simply replacing 'recurse' with 'depth' is the
right course, but note that it will be svn_depth_unknown when the user
didn't pass an explicit depth, because then it just crawls whatever
working copy depths it finds.)
Peter, thanks for the review! It helps a lot to know you're watching.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 8 02:00:42 2007