[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Testers wanted for FSFS svnadmin recover feature (r23595)

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-03-07 20:05:29 CET

On Wed, Mar 07, 2007 at 01:43:46PM -0500, David Glasser wrote:
> I started to run this on my 114285-revision svk depot. The first
> thing I noticed was that it seems to not want to be canceled; it seems
> to ignore SIGINTS, and I had to kill -9 it to cancel it. I assume
> this is intentional?

No, it's not intentional as such, but it's the same behaviour as BDB
recovery, I believe. Unfortunately the current recovery API doesn't
provide for cancellation or feedback, though it should be pretty trivial
to extend the new API to include at least cancellation (for FSFS, anyway)
- does that sound like a good idea?

> More disturbingly, despite the message "Repository lock acquired.", I
> was able to run multiple copies of svnadmin recover on the repository
> at the same time. When I noticed that, I freaked out and killed them
> both; I'll run it for real once I do an actual backup of my computer
> at home sometime soon.

Heh. FSFS recovery doesn't require an exclusive lock, so this is actually
okay. That said, the user experience is certainly sub-optimal, but it's
not entirely clear how we can improve it (the locking is semi-hardcoded
in svnadmin and libsvn_repos). Suggestions welcome.


  • application/pgp-signature attachment: stored
Received on Wed Mar 7 20:05:56 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.