Re: svn commit: r23575 - in trunk/subversion: include libsvn_ra_svn

Daniel Rall wrote:
> Great, thanks Vlad!
>
> Comments:
>
> o SVN_ERR_RA_SVN_NO_MECHANISMS should be a documented return value of
> svn_ra_svn__do_simple_auth().

Right.

> o Aren't "simple" and "sasl" both doing SASL auth from the server's
> perspective? If so, rather than differentiating between "simple" and
> "sasl", wouldn't it be more accurate to label the APIs names and error
> codes "internal" and "external"?

I like 'internal', but maybe we should explicitly use 'cyrus' in the API
names, in case we ever decide to implement another SASL library. Also,
we already have an 'EXTERNAL' SASL mechanism, which would be a source of
confusion.

The files and the server-side functions also use the 'simple' and 'sasl'
names, so we should probably rename those too, for consistency.

> o It doesn't look like you really needed to remove the
> svn_ra_svn__do_auth() interface; of course, what you decided on will
> work fine too.

-- 
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org