[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [issue #2723] 'diff' output, and handling chdir() in multi-threaded applications

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-03-05 20:45:45 CET

On Fri, 02 Mar 2007, Garrett Rooney wrote:

> On 3/2/07, Daniel Rall <dlr@collab.net> wrote:
>
> >If use of chdir() is unsafe for multi-threaded applications, would
> >anyone mind if I added an API to allow control over the file
> >references in Subversion's 'diff' output? If not, how should this new
> >API inter-op with URLs?
>
> chdir is totally unsafe in a multi-threaded application. It is
> essentially modifying global state for which there is no conceivable
> way to do appropriate locking. I don't see any problem with a new API
> to control the behavior, although I have no clue how to make it
> inter-op with URLs.

I've noted this in the issue (to which I've attached a patch
implementing a chdir()-style approach), and outlined very basic plans
for rev'ing the diff API.

  • application/pgp-signature attachment: stored
Received on Mon Mar 5 20:50:09 2007

This is an archived mail posted to the Subversion Dev mailing list.