[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Re: svn commit: r23565 - branches/merge-tracking/subversion/libsvn_client

From: Paul Burba <pburba_at_collab.net>
Date: 2007-03-05 17:46:11 CET

> -----Original Message-----
> From: Daniel Rall [mailto:dlr@collab.net]
> Sent: Monday, March 05, 2007 1:43 AM
> To: dev@subversion.tigris.org
> Subject: Re: svn commit: r23565 - branches/merge-
> tracking/subversion/libsvn_client
>
> On Mon, 05 Mar 2007, Malcolm Rowe wrote:
>
> > On Sun, Mar 04, 2007 at 09:27:09PM -0800, pburba@tigris.org wrote:
> ...
> > > * subversion/libsvn_client/copy.c
> > > (extend_wc_merge_info, wc_to_repos_copy): svn_mergeinfo_merge()
> creates a new
> > > apr_hash_t * for its output hash, so don't make *output the same
as
> either
> > > of the hashes being merged or the mergeinfo in that hash will be
> lost.
> >
> > Maybe the signature of svn_mergeinfo_merge() should change to only
> > accept two hashes, and merge the latter into the former, if that's
the
> > common case? (you could always decide to clone the destination hash
> > first, if you decided you needed to keep a copy around).
>
> This is currently the common case. Though what Malcolm suggests is
> not the prettiest incarnation of this API, it does seem like the most
> efficient and most useful. +1

Done r23570.

Paul B.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 5 17:46:31 2007

This is an archived mail posted to the Subversion Dev mailing list.