Re: [PATCH] Implement recovery for FSFS

On 3/5/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> The attached patch makes "svnadmin recover" do something useful on FSFS
> filesystems. Specifically, it will now recreate the db/current file
> from scratch.

This seems like a good idea.

> Recovery isn't fast - it needs to scan all the revision files in the
> repository - but by hand-coding some of the logic for reading the files,
> I've managed to keep it O(N) for N revisions rather than the O(insanity)
> that the pre-existing generic read functions would have caused.

I don't have time to analyze the performance in depth; it would be
nice if there was a faster way to do it, but I don't see it either.

> * subversion/include/svn_fs.h
> (svn_fs_berkeley_recover): Add notes to explain functionality for FSFS.

Perhaps you should deprecate this and replace it with svn_fs_recover?

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org