[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23538 - in trunk/subversion: include libsvn_client libsvn_wc

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-03-02 07:46:18 CET

Hyrum K. Wright writes:
> While doing so, I found this function tucked in libsvn_client/externals.c:
>
> static svn_boolean_t
> compare_external_items(svn_wc_external_item2_t *new_item,
> svn_wc_external_item2_t *old_item)
> {
...
> }
>
> Should it be moved to libsvn_wc and exposed through the API? (Perhaps
> svn_wc_external_item_eq() ?) If we do expand the external_item
> structure again, equivalence checking should probably extend to the new
> fields as well.
>
I don't think it needs to go public if it is not used anywhere else
(including other users of our libs).
Old code will always miss the new fields. I think we have to live with
that.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 2 07:46:48 2007

This is an archived mail posted to the Subversion Dev mailing list.