[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Destroy the APR subpools

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2007-02-26 16:56:38 CET

On Thu, 2007-02-15 at 18:18 +0530, Bhuvaneswaran Arumugam wrote:
> Hello,
>
> This is a follow-up patch for r23204 for destroying the APR subpools
> before every successful return statement. Please review this patch.
> Thank you.

Any review comment for this patch?

>
> [[
> Destroy the APR subpool before every successful return statement.
>
> * subversion/svnadmin/main.c
> (subcommand_rmlocks):
> * subversion/libsvn_wc/update_editor.c
> (make_editor):
> * subversion/svnsync/main.c
> (do_synchronize):
> Destroy the APR subpool before the successful return statement.
> * subversion/libsvn_repos/log.c
> (get_history): If the history item predates the START revision, then
> destroy the APR subpool and info->oldpool.
> * subversion/libsvn_delta/path_driver.c
> (open_dir): Destroy the APR subpool.
> (svn_delta_path_driver): Destroy the APR subpool and iteration pool to
> prevent iterative pool creation.
>
> Patch by: bhuvan
> ]]

-- 
Regards,
Bhuvaneswaran

Received on Mon Feb 26 16:56:58 2007

This is an archived mail posted to the Subversion Dev mailing list.