[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] (2nd approach) Fix issue #1976: Set arbitrary revision properties (revprops) during commit.

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-02-24 22:04:32 CET

Gerco Ballintijn writes:
> Index: subversion/include/svn_delta.h
> ===================================================================
> --- subversion/include/svn_delta.h (revision 23480)
> +++ subversion/include/svn_delta.h (working copy)
> @@ -699,6 +699,19 @@
> svn_revnum_t target_revision,
> apr_pool_t *pool);
> + /** Change the value of the revision property for this edit.
> + * - @a edit_baton global baton for this change.
> + * - @a name is the name of the revision property to change.
> + * - @a value is the new value of the revision property, or @c NULL if
> + * the revision property should be removed altogether.
> + *
> + * All allocations should be performed in @a pool.
> + */
> + svn_error_t *(*change_rev_prop)(void *edit_baton,
> + const char *name,
> + const svn_string_t *value,
> + apr_pool_t *pool);
> +

As I tried to say in an earlier mail, this is a binary-incompatible
change, which, AFAICT, we can't introduce without creating a new
version of this structure.

Also, while thinking of this, I'm not sure that this commit-specific
function belongs in the general editor interface. An alternative is
to have svn_ra_get_commit_editor() return a callback/baton that can be
used for this purpose. We should restrict the use of this callback to
either before any editing operations to simplify the implementation.
I admit that this is not entirely unugly either. Better suggestions

I'll try to do a complete review of your patch next week apart from
the editor change part. I think you could wait with a next iteration
of the patch until this part of the design is concluded.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 24 22:05:00 2007

This is an archived mail posted to the Subversion Dev mailing list.