[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] (2nd approach) Fix issue #1976: Set arbitrary revision properties (revprops) during commit.

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-02-24 04:56:03 CET

On Sat, Feb 24, 2007 at 02:18:09AM +0100, Gerco Ballintijn wrote:
> 2. Code added to marshall and unmarshall the change-rev-prop command
> for the svn protocol, and deal with this new capability.

I might try to get some time to look at the whole patch later this
weekend, but initially, I'm wondering if there's any reason we need to
announce the command's availability via a capability - does the editor
interface break if we try unknown commands?

IIRC we attempt to run at least lock, unlock, and log-related commands
through the svn protocol and just report an error ('unsupported
feature', I think) back to the client if that failed (and in the log
case, I think we fall back to a slower method of doing the same thing).

Can we not do that here?

Seperate to that is the question of what the command-line tools should
do if run against an older server, of course. Ignoring the problem (as
I suspect the current patch does) probably isn't the right thing to do.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Sat Feb 24 04:56:21 2007

This is an archived mail posted to the Subversion Dev mailing list.