[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r23489 - trunk/subversion/mod_dav_svn/reports

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-02-24 01:33:50 CET

On Fri, 23 Feb 2007, Malcolm Rowe wrote:

> On Fri, Feb 23, 2007 at 03:35:51PM -0800, dlr@tigris.org wrote:
> > Improve memory allocation for the expected case.
> >
> > * subversion/mod_dav_svn/reports/log.c
> > (dav_svn__log_report): Pre-allocate one slot in the "paths" array.
> >
> > - = apr_array_make(resource->pool, 0, sizeof(const char *));
> > + = apr_array_make(resource->pool, 1, sizeof(const char *));
> >
>
> Not that it matters, but APR already does this internally (I guess more
> for convenience than performance, though).

Ah, in make_array_core(). I wasn't aware of that, thanks Malcolm.

- Dan

  • application/pgp-signature attachment: stored
Received on Sat Feb 24 01:32:57 2007

This is an archived mail posted to the Subversion Dev mailing list.