[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: change_rev_prop atomicity

From: David Glasser <glasser_at_mit.edu>
Date: 2007-02-18 19:53:03 CET

On 2/14/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> On Mon, Feb 12, 2007 at 10:50:55AM -0600, Ben Collins-Sussman wrote:
> > Yeah, we should be using the fsfs writelock for that work, shouldn't we?
> >
>
> Yes. The functionality to change the value of a revprop should probably
> move into fs_fs.c, rather than exporting the write-lock code out.

Malcolm,

revs-txns.c currently just contains svn_fs_fs__revision_prop,
svn_fs_fs__change_rev_prop, svn_fs_fs__get_txn_ids,
svn_fs_fs__txn_prop, and svn_fs_fs__begin_txn. The second should move
into fs_fs.c, for locking reasons. Is there any good reason not to
just move them all into fs_fs.c and eliminate revs-txns.[ch] while I'm
at it? It is much smaller than libsvn_fs_base's revs-txns.c.

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Feb 18 19:53:19 2007

This is an archived mail posted to the Subversion Dev mailing list.