[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow clients to check out special files with unknown type

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-02-16 12:05:13 CET

On Fri, Feb 16, 2007 at 09:08:20AM +0100, Peter Lundblad wrote:
> > + /* If we had an error, check to see if it was because this type of
> > + special device is not supported. If so, fall back to using the
>
> "device" ?

Typo, good spot :-) Actually, looks like this typo was already present.
I'll fix it.

> > + internal representation. */
> > + if (err)
> > + {
> > + if (err->apr_err == SVN_ERR_UNSUPPORTED_FEATURE)
>
> Not exactly relevant for what you do, but it just occured to me that if
> the platform supports symlinks, but not the filesystem, EPERM is returned.
> I don't know if it is worth worrying about handling that case though.
> Checking out to a USB stick might be a use case...
>

Indeed, we get EPERM on VFAT - any reason not to add that to the check
above? (I've tested that it works if we do - at least, as well as
it does on Windows).

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Fri Feb 16 12:05:32 2007

This is an archived mail posted to the Subversion Dev mailing list.