[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Bogus operational logging if scheduled commit has got deletion of file(with no lock in repo)

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-02-14 18:41:37 CET

On Wed, 14 Feb 2007, Kamesh Jayachandran wrote:

> Malcolm Rowe wrote:
> >On Wed, Feb 14, 2007 at 06:06:00PM +0530, Kamesh Jayachandran wrote:
> >
> >>>The patch itself looks generally good (although I've not tested it),
> >>>though it did look like it might have caused lines to go over the
> >>>80-character limit.
> >>>
> >>>
> >>It is exactly stops at 80 th character :).
> >>
> >>
> >
> >Well, HACKING does say 'Restrict lines to 79 columns', so technically
> >you probably should have reorganised it slightly to avoid hitting
> >that (probably by assigning the result of svn_path_uri_encode() to a
> >new temporary). But other code in the codebase uses the 80th column,
> >so it's no big deal, and not worth fixing now.
> >
> >
> >>I tested with and without this patch and could observe the fix.
> >>
> >>Committed at r23393.
> >>
> >>
> >
> >I guess my comment above was an approval, though I didn't really mean
> >it to be.
> >
> Sorry I misunderstood it to be.

Patch looks good.

  • application/pgp-signature attachment: stored
Received on Wed Feb 14 18:42:26 2007

This is an archived mail posted to the Subversion Dev mailing list.