[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

change_rev_prop atomicity

From: Chia-liang Kao <clkao_at_clkao.org>
Date: 2007-02-12 13:40:34 CET

While trying to see how to have fs->change_rev_prop_if_value_is() implemented
for better atomicity, I saw something interesting in the related code.

In libsvn_fs_fs/revs-txns.c: svn_fs_fs__change_rev_prop, the __set_rev_prop
called is loading the revision proplist hash, changing the value for what is
requested, and writing back the whole hash as the new proplist. The code is
vulnerable for race condition when two clients are setting different revision
properties on the same revision at the same time.

Cheers,
CLK

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Feb 12 13:41:36 2007

This is an archived mail posted to the Subversion Dev mailing list.