Hi Peter,
the new version is attached. Thank you very much for legal stuff issues
pointing. Please let me know if you have any more notes.
Peter Samuelson wrote:
> [Vyacheslav Iutin]
>> # Copyright (c) 2007, Whirix Ltd.
>> # All rights reserved.
>> # Author: Vyacheslav Iutin <iutinvg@yahoo.com>
>> #
>> # Licenced under the same terms as Subversion.
>
> Hmmm, isn't "All rights reserved" the opposite of "Licensed under..."?
>
>
>> if [ -d $dir ] ; then
>> tempdir=`mktemp -d $dir.XXXXXX`
>
> You should mention somewhere that this script requires the mktemp
> program, which is not standard on Unix.
>
>> mv -v $dir/* $tempdir
>> rm -r -v $dir
>
> You should mention somewhere that this script requires GNU coreutils;
> otherwise, I don't believe mv, rm, cp and mkdir can be assumed to
> support the -v option, nor will cp support -a.
>
>> if [ ! -d $listItem ] ; then
>> mkdir -v -p $dir/`dirname $listItem`
>> cp -a -v $listItem $dir/$listItem
>> fi
>
> This appears to copy the HEAD revision of each file or directory. Are
> you sure this is what you intended? I would have expected to get the
> file as of r345, or whatever revision I passed in to the script.
>
> Also, did you mean to recursively copy added or modified directories?
> Including the .svn/ metadata subdirectory? That is not what I would
> expect when running a script like this.
>
> Finally, I suggest quoting your filenames; some people use subversion
> to store filenames with spaces and other interesting characters.
--
Regards,
Slava
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 8 08:49:25 2007